[libsolidity] Refactor Compiler Stack imported source type. #13578
Conversation
There was a problem hiding this comment.
I personally like this approach more than the ternary operator, although @cameel and/or @ekpyron may disagree. However, I do find it weird that this isn't covered by any unit tests and feel as though it should probably be done in test/libsolidity/Metadata.cpp. In any case, I'd prefer to have this covered by tests, but since you'll need the final sign off by @cameel or @ekpyron for merging, I'm comfortable with approving this.
| string sourceType; | ||
| switch (m_importedSourceType) | ||
| { | ||
| case ImportedSourceType::None: |
There was a problem hiding this comment.
I guess this is technically in line with the previous implementation using bool, but it's kind of confusing that None returns Solidity.
There was a problem hiding this comment.
I actually think we should just call it compilationSourceType or something. The metadata also just calls it "sourceType". At some point we might also use "Yul" as source type, so this has nothing to do with it being imported or not.
chriseth
force-pushed
the
imported-source-type-refactoring
branch
from
12ad902 to
0da1ce3
Compare
Refactors
libsolidity/interface/CompilerStack.cppto make #12834 more readable.